Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors when uploading key signatures #11574

Closed
jryans opened this issue Dec 2, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4229
Closed

Handle errors when uploading key signatures #11574

jryans opened this issue Dec 2, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4229
Assignees

Comments

@jryans
Copy link
Collaborator

jryans commented Dec 2, 2019

We currently do not check for errors when uploading key signatures (JS SDK method uploadKeySignatures). This is probably because the failures are returned inline in the response for each signature, rather than in the top-level HTTP response code.

We should track these errors and communicate failure to the user somehow.

@nadonomy
Copy link
Member

When does this happen specifically in the user journey? Does it happen when bootstrapping? (as I see it was referenced in #11212). Can it happen in any other instances?

@t3chguy
Copy link
Member

t3chguy commented Feb 21, 2020

image

@nadonomy
Copy link
Member

I think given the failure mode is that users can't complete their goal— out of pragmatism for now I'd throw up an error message in a modal, where they can hit OK and start doing whatever they were attempting again.

If this turns out to be a very common failure mode we could polish this into much nicer contextual error feedback.

@foldleft foldleft self-assigned this Feb 25, 2020
@foldleft foldleft added this to In Progress in Web App Team via automation Feb 25, 2020
@foldleft
Copy link
Contributor

@foldleft foldleft removed their assignment Feb 27, 2020
@foldleft foldleft removed this from In Progress in Web App Team Feb 27, 2020
@foldleft foldleft self-assigned this Mar 5, 2020
@foldleft foldleft added this to In Progress in Web App Team via automation Mar 5, 2020
@foldleft foldleft moved this from In Progress to In Review in Web App Team Mar 17, 2020
Web App Team automation moved this from In Review to In Test Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants