Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use distinct user badging for non-cross-signing users #12806

Closed
jryans opened this issue Mar 20, 2020 · 6 comments
Closed

Use distinct user badging for non-cross-signing users #12806

jryans opened this issue Mar 20, 2020 · 6 comments

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 20, 2020

For those users who don't want to use cross-signing, we should use a distinct badge to mark their user profile. Perhaps a gray shield instead of a black shield, but design is still TBD.

@nadonomy
Copy link
Member

nadonomy commented Apr 2, 2020

@jryans sorry missed this, can you trace me with the logic/decision making on this one? One of the foundational principles for the new icon language is that existing of a shield simply states whether or not encryption exists, and then we have the verified & unverified states from there.

We could expose this by using an HTML tooltip on a black shield? Relabelling this as suggestion until we chew the fat on this more.

@jryans
Copy link
Collaborator Author

jryans commented Apr 2, 2020

@nadonomy This came about when discussing TOFU options with @ara4n.

We said things like "People who have cross-signing disabled are decorated distinctly/grey", but the exact meaning of that design was not determined.

@nadonomy
Copy link
Member

nadonomy commented Apr 2, 2020

@jryans that was my understanding too, but that entire document is WIP, and is an encapsulated body of work slated for future.

I think we might be wiser to not leave open issues for things like this— for TOFU specifically other than perhaps one parent issue describing our intentions as far as we understand them at a high level, linking to the doc. Or, I’m also happy leaving it open with the suggestion label until we commit to it as part of a holistic solution.

As it stands this issue is written as absolute and is focused on an exact solution we’ve yet to validate. In the past that’s tripped us up when picking up again after time as it can mislead requirements.

@jryans
Copy link
Collaborator Author

jryans commented Apr 2, 2020

@nadonomy Hmm, okay I think we interpreted the situation differently... I guess when talking about it at the time, I had interpreted this precise piece about "People who have cross-signing disabled" as something we want to label / denote whether or not any other piece of TOFU work happens.

In my mind, this current issue applies also to users who disable cross-signing (we already added such an option as part of assisting those who require manual key comparison).

I think we might be wiser to not leave open issues for things like this— for TOFU specifically other than perhaps one parent issue describing our intentions as far as we understand them at a high level, linking to the doc. Or, I’m also happy leaving it open with the suggestion label until we commit to it as part of a holistic solution.

If it were just about TOFU, I would likely agree, but that's the confusion I think: there already is a set of users without cross-signing that this issue applies to with the product in-flight on develop without doing anything about TOFU.

As it stands this issue is written as absolute and is focused on an exact solution we’ve yet to validate. In the past that’s tripped us up when picking up again after time as it can mislead requirements.

Okay, just trying to capture what we discussed, as it seemed highly likely to be forgotten otherwise, and again it is something that exists outside of the TOFU context. We can happily edit the issue however we need to, or close it if we are fine with people that opt out of cross-signing receiving the default badging.

@nadonomy
Copy link
Member

nadonomy commented Jun 2, 2020

Okay, just trying to capture what we discussed, as it seemed highly likely to be forgotten otherwise, and again it is something that exists outside of the TOFU context. We can happily edit the issue however we need to, or close it if we are fine with people that opt out of cross-signing receiving the default badging.

I'd be inclined to close this out. The issue description doesn't describe a user goal we're trying to satisfy.

@kittykat
Copy link
Contributor

kittykat commented Dec 9, 2021

I'm going to close this issue for now as per N4d's comment as designs have changed since it's been filed. Please open a new issue if you feel that there are improvements to be made.

@kittykat kittykat closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants