New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a chrome extension to enable screensharing #238

Open
matrixbot opened this Issue Oct 21, 2015 · 25 comments

Comments

Projects
None yet
@matrixbot
Copy link
Collaborator

matrixbot commented Oct 21, 2015

Created by @ matthew:matrix.org.

@ara4n ara4n added feature p2 labels Oct 22, 2015

@ara4n ara4n added p3 and removed p2 labels Nov 24, 2015

@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015

@ara4n ara4n removed this from the Ragnarok milestone Apr 13, 2016

@ara4n ara4n referenced this issue Jan 5, 2017

Closed

Screen sharing #2888

@uhoreg uhoreg referenced this issue Jan 26, 2017

Open

Voice/Video Conference Wishlist #3025

0 of 15 tasks complete
@carlos22

This comment has been minimized.

Copy link

carlos22 commented Feb 17, 2017

What about the Electron app? There is a alpha-web-rtc screen share tool: https://github.com/maxogden/screencat - it uses RobotJS (https://github.com/octalmage/robotjs). Don't know how that is related to the chrome screencast stuff.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented May 15, 2017

@carlos22 oops - missed this. the electron app already does screensharing - shift-click the video call button. (we'll make it more obvious in future)

@tanius

This comment has been minimized.

Copy link

tanius commented Jul 4, 2017

Clarification for people wanting to try screensharing from Chrome / Chromium: no need to install an extension, just start Chrome / Chromium with the --enable-usermedia-screen-capturing command-line option and then do a Shift+click on the Riot video call button. Tested it, works. (source)

In addition, I tried several extensions for Chrome / Chromium but did not find any that would make Shift+click video calls work in Riot without the --enable-usermedia-screen-capturing command-line argument.

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Jul 4, 2017

The latter is because riot-web (matrix-js-sdk actually) would need to understand the specific extensions and communicate with them especially

@danielg4

This comment has been minimized.

Copy link

danielg4 commented Aug 19, 2017

OK, shift-clicking the video call button does screen sharing, which is not intuitive at all, but there doesn't appear to be a way to switch between camera and screen sharing without leaving the call first…

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Aug 19, 2017

Because it is an easter egg currently, in the next gen conferencing, available via Matrix Apps screensharing is seamless and via its own button and you can switch on the fly

@akontsevich

This comment has been minimized.

Copy link

akontsevich commented Nov 30, 2017

Because it is an easter egg currently, in the next gen conferencing, available via Matrix Apps screensharing is seamless and via its own button and you can switch on the fly

What version it will appear and when? Does Shift-click work in desktop version?

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Nov 30, 2017

@akontsevich the current version has Jitsi support but I believe Jitsi screensharing in desktop is currently broken

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Nov 30, 2017

I think it was fixed in 0.13?

@akontsevich

This comment has been minimized.

Copy link

akontsevich commented Nov 30, 2017

@t3chguy I need Riot<->Riot screensharing. Jitsi not interesting to me.

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Nov 30, 2017

Riot has Jitsi widgets within it, Jitsi is replacing the "native" (freeswitch/verto) conferencing stack in Riot. @akontsevich

@akontsevich

This comment has been minimized.

Copy link

akontsevich commented Nov 30, 2017

Riot has Jitsi widgets within it, Jitsi is replacing the "native" (freeswitch/verto) conferencing stack in Riot. @akontsevich

I see, thanks. Shift-Click on phone call button will work after this? I see that Jitsi is something standalone. So video calls in Riot works only for p2p? Does not work for multiple people in a room?

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Dec 14, 2017

ftr, when using Jitsi you're very plainly asked to install the extension. When Jitsi becomes embedded in Riot, this issue can probably be closed.

@MurzNN

This comment has been minimized.

Copy link
Contributor

MurzNN commented Mar 5, 2018

Will Jisti widget replace also direct one-to-one calls in Riot? Seems now they are working directly via p2p, and in future will works through Jisti server?

@jaller94

This comment has been minimized.

Copy link

jaller94 commented Jul 1, 2018

The most recent update made Jitsi the default for video calls.
Jitsi supports screen sharing on modern web browsers.

https://github.com/vector-im/riot-web/releases/tag/v0.15.6

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Jul 1, 2018

In 1:1 I believe jitsi isn't the default.

@Zjemm

This comment has been minimized.

Copy link

Zjemm commented Jul 6, 2018

i hope they wont use jitsi for 1:1, its a dependency on another service which defeats the purpose of running your own instance.

for large groups it could be usefull, altough you first need to add a widget in order to start a conference. there should be just native button for that without the use of widgets.....Dont make riot like KDE :P

and for screensharing, i would be best if it was native and not dependent on jitsi
if i want to sell matrix/riot as a slack/skype replacement for companies.....this will be a deal breaker unfortunately

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Jul 6, 2018

You can self host jitsi
See dimension.t2bot.io

@mnn

This comment has been minimized.

Copy link

mnn commented Aug 1, 2018

@akontsevich the current version has Jitsi support but I believe Jitsi screensharing in desktop is currently broken

Confirming, still broken in the standalone app (0.15.7). 😞 This is probably only feature I am truly missing.

@akontsevich

This comment has been minimized.

Copy link

akontsevich commented Aug 1, 2018

Broken in v0.16 as well on desktop.

@MurzNN

This comment has been minimized.

Copy link
Contributor

MurzNN commented Aug 10, 2018

Does this extension https://chrome.google.com/webstore/detail/riotim-screen-sharing/ehgcnaneidbjcmblghjepmamomchgahd solve the problem in Chrome browser? For me - yes.

@BloodyIron

This comment has been minimized.

Copy link

BloodyIron commented Nov 22, 2018

So screen sharing works for me on desktop as of this writing, however we really need some core functionality in order for it to be actually useful.

  1. Actual UX features to share screen (screen sharing button dedicated please), the hidden shortcut nobody will find (I suspect that's intentional right now though).
  2. The ability to select, all monitors/one specific monitor/specific app/screen region (drag and resize perhaps?)
  3. The ability to CHANGE visible scope without restarting the call (including dis/enabling screen sharing without dropping the call).
  4. The ability to share screen without video being required on the other ends. Sharing to users without webcams on their end must be an option.
  5. Some sort of way to highlight the region that is being shared, so the user doesn't forget their sharing content (UX)

The fact it works with zero effort out of the box right now, suggests to me most of the work is already done, we just need this polish for it to be actually rad ;)

So, apart from my proposals here, what exactly is the current plan/status for screen sharing in riot? (including android and ios)

@BloodyIron

This comment has been minimized.

Copy link

BloodyIron commented Nov 22, 2018

Also, I'm not sure if screen sharing works in a room chat right now (conference?). As it talks about failinng to accesxs my camera....

@MurzNN

This comment has been minimized.

Copy link
Contributor

MurzNN commented Nov 22, 2018

@BloodyIron did you write about internal p2p screensharing function in Riot (via shift+click hack) or about new implementation via Jitsi library? Old p2p versions seems to be dropped in future, replaced via Jitsi library: #4880

@BloodyIron

This comment has been minimized.

Copy link

BloodyIron commented Nov 22, 2018

Yeah my testing was as of today, so AFAIK this is Jitsi relevant. Does that answer your question? :)

Part of it is p2p (jitsi anyways though?) and part of it is room conferencing though, so both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment