Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging from people section to rooms doesn't behave as expected #3449

Closed
dbkr opened this issue Mar 16, 2017 · 3 comments
Closed

Dragging from people section to rooms doesn't behave as expected #3449

dbkr opened this issue Mar 16, 2017 · 3 comments
Labels
P2 S-Tolerable Low/no impact on users T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Mar 16, 2017

Should un-set the DM flag, but doesn't, so basically doesn't really work.

This is because of matrix-org/matrix-react-sdk#754
@lukebarnard1
Copy link
Contributor

Copied from matrix-org/matrix-react-sdk#754

you can drag a "People" to "Rooms", but it won't set the direct chat flag. This is because im.vector.fake.direct != m.direct, sadly.

The subtly I think is in the way DMs are stored on the client.

@lukebarnard1 lukebarnard1 mentioned this issue Mar 17, 2017
Merged
@t3chguy
Copy link
Member

t3chguy commented Sep 9, 2020

We no longer have dnd

@t3chguy t3chguy closed this as completed Sep 9, 2020
@turt2live
Copy link
Member

I think you meant "Closing in favour of #8614" ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dbkr @turt2live @lampholder @t3chguy @lukebarnard1