Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long homeserver domain names and internationalisation to longer languages (like French) break "Sign in with" box #5767

Closed
justin-sleep opened this issue Dec 2, 2017 · 6 comments
Assignees
Labels
A-Login P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect

Comments

@justin-sleep
Copy link

Description

Riot's login page has a "Sign in with" box, which lists the options to authenticate with. The text overflows out of the box when the domain name is too long.

Steps to reproduce

  • Point Riot to a homeserver with a long domain name

2017-12-01-19 51 54

Version information

Web, 0.13.2

Present on latest versions of Chromium and Firefox.

@lampholder
Copy link
Member

Quick fix: truncate with ellipsis.

Controversial longer fix: bring back the enhanced user name button that I mooted at some point in the past with the @ and the domain baked into the username field (I think people didn't like it):

[@| User name |:matrix.org]

[@| User name |:lant.uk]

@lampholder lampholder added T-Defect S-Tolerable Low/no impact on users S-Minor Impairs non-critical functionality or suitable workarounds exist P2 A-Login ui/ux labels Dec 6, 2017
@pafcu
Copy link
Contributor

pafcu commented Dec 6, 2017

This is a common problem all around Riot and there are several related issues with the same symptoms (i.e. text does not fit into combobox). It seems like a generic solution is needed, so probably the ellipsis one is the best (although certainly it is possible to additionally special case this one)

@lampholder lampholder changed the title Long homeserver domain names break "Sign in with" box Long homeserver domain names and internationalisation to longer languages (like French) break "Sign in with" box Mar 27, 2018
@lampholder lampholder added P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist P2 labels Mar 27, 2018
@ara4n
Copy link
Member

ara4n commented Sep 12, 2018

ellipsising ftw for now as quick fix, although it obviously opens the door to nasty phishing attacks if matthew.modular.im gets truncated so matthew.modular.im.evil.com could be injected too. should be fixed properly in redesign.

@lampholder lampholder added this to To Do in First Impressions Sep 26, 2018
@turt2live
Copy link
Member

The whole dropdown can probably be removed when element-hq/element-meta#1582 is implemented

@turt2live
Copy link
Member

Conclusion: we're going to use an ellipsis and punt the remainder to the redesign (#7586)

@turt2live turt2live assigned turt2live and unassigned nadonomy Dec 19, 2018
@turt2live turt2live moved this from To Do to In Progress in First Impressions Dec 19, 2018
@turt2live turt2live added this to In Progress in Web App Team Dec 19, 2018
@turt2live
Copy link
Member

This was actually fixed long ago by #6244

First Impressions automation moved this from In Progress to Done Dec 19, 2018
@turt2live turt2live moved this from In Progress to Done in Web App Team Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Login P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect
Projects
No open projects
Development

No branches or pull requests

6 participants