Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable all identity server functionality via the config file #5921

Closed
turt2live opened this issue Jan 4, 2018 · 12 comments · Fixed by matrix-org/matrix-react-sdk#3285

Comments

@turt2live
Copy link
Member

commented Jan 4, 2018

By setting the default_is_url to an empty string/null or something.

@lampholder

This comment has been minimized.

Copy link
Member

commented Jan 8, 2018

Interesting. What consequences would this have?

Threepid invites wouldn't work; what else?

@lampholder

This comment has been minimized.

Copy link
Member

commented Jan 8, 2018

Also, just so I'm not guessing, what's the reason behind this?

@turt2live

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2018

Someone wanted it for privacy concerns (I really should have linked the message). They were concerned that their users would accidentally use the identity server in a privacy-centric group.

The other thing (that I know of) to disable would be adding/editing 3pids.

@jasmir

This comment has been minimized.

Copy link

commented Jan 29, 2019

Is there any movement here? I'd like to add that using the .well-known/matrix/client stuff for it would be very convenient.
For example by "m.identity_server": { "base_url": "" }

@meskio

This comment has been minimized.

Copy link

commented Mar 15, 2019

As a work around I've notice that having an 'identity server' that just replies an application/json {} in https://example.com/_matrix/identity/api/v1 works to keep riot happy and don't use an identity server.

But will be really nice to get an official way to disable the identity server.

@aaronraimist

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Would also be nice to have this when the identity server you wanted to use is down :)

@lampholder

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@aaronraimist

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Doesn't matrix-org/matrix-react-sdk#3088 fix 90% of this? All you need to do now is make it also work with a completely blank field instead of only working if you enter a URL that isn't an identity server.

Related: #10274

@dbkr dbkr self-assigned this Aug 2, 2019
@dbkr dbkr added this to In Progress in Workflow Aug 2, 2019
@dbkr dbkr removed this from In Progress in Workflow Aug 2, 2019
@dbkr dbkr removed their assignment Aug 2, 2019
@lampholder lampholder changed the title Ability to disable all identity server functionality Ability to disable all identity server functionality via the config file Aug 2, 2019
@lampholder

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Updated the issue title to distinguish it from #10425

@dbkr dbkr self-assigned this Aug 6, 2019
@dbkr dbkr added this to In Progress in Workflow Aug 6, 2019
@dbkr

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Annoyingly we overlooked this in MSC2078 and the id_server param is still require in all situations, so spec-wise we'd be unable to register with an email at all if no IS were specified, even if the HS sends its own emails.

@turt2live points out that (again, spec-wise) a solution to this could be to abuse params from UIA to have a flag for requires_identity_server: true/false. Default true.

@rubo77

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

Why is this closed?

@t3chguy

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2019

Because it got implemented by #3285?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
9 participants
You can’t perform that action at this time.