New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two scrollbars in Firefox #6694

Open
fladd opened this Issue May 9, 2018 · 12 comments

Comments

6 participants
@fladd
Copy link

fladd commented May 9, 2018

Description

In Firefox, there are two issues with scrolling:

  1. Scrolling is "jumpy", probably related to dynamically loading content from the chat history
  2. There are two scrollbars (superimposed on each other)

Steps to reproduce

  • Scroll the chat window

Describe how what happens differs from what you expected.

I expect these issues to not happen.

Log: not sent

image

Version information

  • Platform: web (in-browser) or desktop?
    web (develop)

For the web app:

  • Browser: Firefox (59, 60)

  • OS: Windows, macOS

  • URL: riot.im/develop
    For the desktop app:

  • OS: Windows, macOS

  • Version: current

@lampholder

This comment has been minimized.

Copy link
Member

lampholder commented May 29, 2018

The first part of this (jumpy scrolling) is #2646

The second part of this is a known limitation of a 'fix' to gemini scrollbar - gemini replaces the browser native scrollbar with one that is aesthetically more pleasing (and mac-like, as it happens). By default, gemini doesn't replace the current scrollbar if it thinks it's pretty enough, however this logic was malfunctioning resulting in some sections of the app not being scrollable.

tl;dr we forced gemini scrollbar to always be active, which caused some (known) double scrollbar fun but we didn't think it was noticable, so the bug here is that the current setup results in some quite obvious and ugly double scrollbar :(

I'm going to rename the bug to focus on the double scrollbar and leave #2646 to track the jumpiness.

@lampholder lampholder changed the title Scrolling issues in Firefox Two scrollbars in Firefox May 29, 2018

@fladd

This comment has been minimized.

Copy link
Author

fladd commented May 29, 2018

Thanks for the answer. I don't really understand why replacing a well proven standard element like a browser's native scrollbar with some less proven third-party alternative was necessary (not sure what is unaesthetic about a normal scrollbar), but I think it would be great if this could be deactivated by users who value function over form.

@aaronraimist

This comment has been minimized.

Copy link
Contributor

aaronraimist commented Oct 5, 2018

This is also present in Safari

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Oct 19, 2018

I'm not seeing this in Firefox 62 (Windows 10) - is it still happening for people?

Also I don't have a Safari to test with, but maybe it magically got fixed in the last 14 days? (please say yes...)

@turt2live turt2live moved this from To Do to Needs more information in First Impressions Oct 19, 2018

@aaronraimist

This comment has been minimized.

Copy link
Contributor

aaronraimist commented Oct 19, 2018

@turt2live No it hasn't gotten fixed in /develop for Firefox, Chrome, or Safari on macOS. I cannot reproduce in Firefox on Elementary OS (Ubuntu) so it may be a macOS only bug (although the original reporter said they found it on Windows too).

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Oct 19, 2018

I'm going to pin it as a Mac issue then and hope someone has the bandwidth to fix it

@turt2live turt2live moved this from Needs more information to Can't Fix (see labels on issues) in First Impressions Nov 5, 2018

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Nov 9, 2018

ftr, this is likely going to be fixed in the upcoming redesign.

@aaronraimist

This comment has been minimized.

Copy link
Contributor

aaronraimist commented Nov 9, 2018

@turt2live fixed by getting rid of Gemini or what?

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Nov 9, 2018

I think that's the current plan, although it's somewhat subject to change. Getting rid of gemini is a long-term goal of the project in the first place and is likely to be the route taken.

@klopsi

This comment has been minimized.

Copy link

klopsi commented Jan 4, 2019

Firefox renders this page with two scrollbars and pgup/pgdn doesn't work.
[screencap] https://0x0.st/sROe.png
Page works fine in chromium, epiphany-browser, qupzilla, konqueror, qutebrowser.
Is this related to this bug? Can it be fixed?
Firefox Version: 64.0-1 - has been a problem for over a year at least.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Feb 10, 2019

this is still the case currently in the redesign. it should be fixed by killing off gemini everywhere.

@fladd

This comment has been minimized.

Copy link
Author

fladd commented Feb 14, 2019

still happening in 1.0 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment