Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages in the room are often quickly scrolled out of view when a typing notification appears #9205

Closed
jimmycuadra opened this issue Mar 18, 2019 · 8 comments
Assignees

Comments

@jimmycuadra
Copy link

@jimmycuadra jimmycuadra commented Mar 18, 2019

Description

Sometimes when a typing notification appears in a room, the previously sent messages that are visible in the viewport quickly start scrolling up off the top of the screen, as if someone was sending a bunch of empty messages very fast. It doesn't happen every time, but has been happening frequently for me, maybe 3-4 times an hour in a room with ongoing discussion.

Steps to reproduce

  • Chat with people in a room.
  • Wait for it to happen.

Log: Not sent thus far, but I could send one if it's needed to diagnose.

Version information

  • Platform: Desktop (macOS)
@jimmycuadra jimmycuadra added the bug label Mar 18, 2019
@chrissphinx

This comment has been minimized.

Copy link

@chrissphinx chrissphinx commented Mar 19, 2019

Here is a short video showing this bug: https://gfycat.com/fantasticadmiredarctichare

@ara4n

This comment has been minimized.

Copy link
Member

@ara4n ara4n commented Mar 19, 2019

i haven't seen this particular failure mode before, but we've almost finished entirely rewriting the timeline scrolling logic, which will fix this and a few billion other similar issues.

@ara4n

This comment has been minimized.

Copy link
Member

@ara4n ara4n commented Mar 19, 2019

(matrix-org/matrix-react-sdk@71f6b08 is where the rewrite is happening ftr)

@jimmycuadra

This comment has been minimized.

Copy link
Author

@jimmycuadra jimmycuadra commented Mar 20, 2019

It's almost certainly gotten much worse since the last Riot update, so maybe a diff between that release and the previous one can help narrow down the cause.. It's happening often enough that it's bordering on unusable on my most active room. All my friends are getting super frustrated with it >_<

@strixaluco

This comment has been minimized.

Copy link
Contributor

@strixaluco strixaluco commented Mar 20, 2019

Me and my contacts are now experiencing this too, but it never occurred before — started to happen today. We are on Riot Desktop 1.0.4 (GNU/Linux and Windows)

@bwindels bwindels self-assigned this Mar 20, 2019
@bwindels bwindels added this to Raging Inferno 🔥🔥🔥 in Workflow Mar 20, 2019
@bwindels bwindels moved this from Raging Inferno 🔥🔥🔥 to In Progress in Workflow Mar 21, 2019
@bwindels bwindels moved this from In Progress to In Test in Workflow Mar 21, 2019
@bwindels bwindels moved this from In Test to Done in Workflow Mar 21, 2019
@bwindels

This comment has been minimized.

Copy link
Contributor

@bwindels bwindels commented Mar 21, 2019

Released 1.0.5 as a hotfix, disabling the jump prevention when typing notifs disappear. We'll bring the jump prevention back soon though, as part of the rewrite of timeline scrolling (#8565) though, hopefully in the next release.

@bwindels

This comment has been minimized.

Copy link
Contributor

@bwindels bwindels commented Mar 21, 2019

1.0.5 is now live on https://riot.im/app/

@bwindels

This comment has been minimized.

Copy link
Contributor

@bwindels bwindels commented Mar 21, 2019

Closing, please reopen should this still occur on 1.0.5.

@bwindels bwindels closed this Mar 21, 2019
Workflow automation moved this from Done to In Test Mar 21, 2019
@bwindels bwindels moved this from In Test to Done in Workflow Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.