Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Cross Signing: Remaining items (backend) #9631

Closed
lampholder opened this issue May 3, 2019 · 5 comments

Comments

@lampholder
Copy link
Member

@lampholder lampholder commented May 3, 2019

  • Tidy Synapse code (early-to-mid next week)
    • clean up upload_signing_keys_for_user and convert to use 3-key system
    • convert sytests to use 3-key system
    • convert unit tests to use 3-key system
    • clean up upload_signatures_for_device_keys
    • make sure federation works with 3-key system
    • when user-signing key is changed, only user should be notified (should be done, but not tested yet)
    • add lots of comments
    • split into 2 PRs
    • update spec
  • Make sure that cross-signing key changes are handled correctly
  • Switch to 3-key system
  • Making the clients stay in sync with each other e.g. if one device signs a key, then other devices will trust it
  • Sharing cross-signing keys when you add a new device
  • Update SAS functions to verify the cross-signing key
  • Write a quick demo
  • Update key backup to be signed/verified by cross-signing key
  • Migrate device verifications to master key verifications
    • Synapse
    • js-sdk
    • MSC
@lampholder

This comment has been minimized.

Copy link
Member Author

@lampholder lampholder commented May 3, 2019

@lampholder lampholder added this to In Progress in Workflow via automation May 3, 2019
@Thatoo

This comment has been minimized.

Copy link

@Thatoo Thatoo commented May 22, 2019

Is cross-signing on android/Riot and android/RiotX at the same stage that on Riot-web (Riot desktop)?
I guess iOS user are wondering the same too, so same question for them.

@ara4n

This comment has been minimized.

Copy link
Member

@ara4n ara4n commented May 24, 2019

no, we're doing the initial implementation on riot/web (aka riot/desktop) and testing it there. if it works well in practice, then the mobile clients will port over the code. we won't bother porting it to riot/android, only riotx.

@Thatoo

This comment has been minimized.

Copy link

@Thatoo Thatoo commented Oct 30, 2019

It looks like we are very close to get this feature working and available on Riot, doesn't it?

@uhoreg uhoreg changed the title E2E: Cross Signing: Remaining items E2E: Cross Signing: Remaining items (backend) Nov 1, 2019
@uhoreg

This comment has been minimized.

Copy link
Member

@uhoreg uhoreg commented Nov 1, 2019

The synapse bits are all merged now. We will track the JS SDK part via its own PR, and the UI parts have their own issues, so I'm going to close this issue.

@uhoreg uhoreg closed this Nov 1, 2019
Workflow automation moved this from In Review to In Test Nov 1, 2019
@richvdh richvdh mentioned this issue Nov 6, 2019
7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.