Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a red box of anger for config syntax errors #10193

Merged
merged 2 commits into from Jun 27, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Jun 27, 2019

Copy link
Collaborator

t3chguy left a comment

Yay :D

@turt2live turt2live requested a review from lampholder Jun 27, 2019
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Jun 27, 2019

(asking @lampholder for quick copy review)

@turt2live turt2live requested review from t3chguy and removed request for lampholder Jun 27, 2019
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Jun 27, 2019

@t3chguy please take another look. Note this is now a 2-part PR: matrix-org/matrix-react-sdk#3154

@turt2live turt2live merged commit 975f177 into develop Jun 27, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #542 passed (2 minutes, 38 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (49 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 27 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (3 seconds)
Details
@turt2live turt2live deleted the travis/syntax-error branch Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.