Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #10260

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@jryans
Copy link
Member

jryans commented Jul 4, 2019

I checked the Webpack release notes for the upgrade included below. (There didn't seem to be anything surprising.)

@jryans jryans requested a review from vector-im/riot-web Jul 4, 2019
@jryans jryans added this to In Review in Workflow Jul 4, 2019
Copy link
Member

turt2live left a comment

We should update the package.json as well with the latest versions we're using. This saves some steps when investigating which versions of things we're using.

Otherwise lgtm - it's a lockfile change with no obvious steal-my-keys packages.

@jryans jryans requested a review from turt2live Jul 5, 2019
@jryans

This comment has been minimized.

Copy link
Member Author

jryans commented Jul 5, 2019

The PR is the result of running yarn upgrade, which doesn't appear to touch package.json. I then tried yarn upgrade-interactive and syncyarnlock, but neither did the right thing. 😭

Copy link
Member

turt2live left a comment

as mentioned in #riot-dev, we should just merge this because it's difficult to update the package.json for now

@jryans jryans merged commit cb92e1d into develop Jul 5, 2019
4 checks passed
4 checks passed
buildkite/riot-web Build #576 passed (2 minutes, 19 seconds)
Details
buildkite/riot-web/eslint-lint Passed (37 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 14 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
Workflow automation moved this from In Review to In Test Jul 5, 2019
@jryans jryans moved this from In Test to Done in Workflow Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.