Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify i18n in CI #10320

Merged
merged 2 commits into from Jul 12, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Jul 11, 2019

@turt2live turt2live referenced this pull request Jul 11, 2019
@turt2live turt2live force-pushed the travis/ci-i18n branch from a08e27c to c22e03a Jul 11, 2019
@turt2live turt2live marked this pull request as ready for review Jul 11, 2019
@turt2live turt2live requested a review from vector-im/riot-web Jul 11, 2019
@turt2live turt2live added this to In Review in Workflow Jul 11, 2019
@@ -0,0 +1,10 @@
const fs = require("fs");

This comment has been minimized.

Copy link
@bwindels

bwindels Jul 12, 2019

Contributor

wonder if we could use a command like diff (sets $? to 0 on no difference apparently) instead, but that's not always available on windows I suppose?

Just an idea, this is fine too.

This comment has been minimized.

Copy link
@turt2live

turt2live Jul 12, 2019

Author Member

it is indeed not available :(

@turt2live turt2live merged commit 6762727 into develop Jul 12, 2019
5 checks passed
5 checks passed
buildkite/riot-web/pr Build #618 passed (2 minutes, 37 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (43 seconds)
Details
buildkite/riot-web/pr/i18n Passed (1 minute, 39 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 28 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (8 seconds)
Details
Workflow automation moved this from In Review to In Test Jul 12, 2019
@turt2live turt2live deleted the travis/ci-i18n branch Jul 12, 2019
@jryans jryans moved this from In Test to In RC in Workflow Aug 1, 2019
@jryans jryans moved this from In RC to Done in Workflow Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.