Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Electron 5 #10392

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@jryans
Copy link
Member

jryans commented Jul 22, 2019

The APIs related to custom protocols went through some changes for Electron 5.x,
so adjusts Riot's usages to match.

I have scanned the Electron 5.x release notes, and I can't see anything else
that requires immediate changes. Things appear to be working well after the
upgrade.

Fixes #10296
Fixes #9562
Fixes #10388

The APIs related to custom protocols went through some changes for Electron 5.x,
so adjusts Riot's usages to match.

I have scanned the Electron 5.x release notes, and I can't see anything else
that requires immediate changes. Things appear to be working well after the
upgrade.

Fixes #10296
Fixes #9562
@jryans jryans requested a review from vector-im/riot-web Jul 22, 2019
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Jul 23, 2019

from a code point of view, lgtm. Leaving in the queue to get electron-expert review.

Copy link
Contributor

bwindels left a comment

as Travis said, code looks good, but I'm also not fully aware of all the things that can break here, especially given we don't do nightlies for electron. Maybe a third pair of 👀 wouldn't be bad...

@dbkr
dbkr approved these changes Jul 23, 2019
Copy link
Member

dbkr left a comment

Yep, lgtm

@jryans jryans merged commit 55e2f18 into develop Jul 23, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #674 passed (2 minutes, 48 seconds)
Details
buildkite/riot-web/eslint-lint Passed (48 seconds)
Details
buildkite/riot-web/i18n Passed (1 minute, 47 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 38 seconds)
Details
buildkite/riot-web/pipeline Passed (9 seconds)
Details
@jryans jryans referenced this pull request Jul 23, 2019
Bendodroid added a commit to Bendodroid/void-packages that referenced this pull request Oct 4, 2019
- Adjust template.
- Delete patch only needed for electron5-incompatible versions.
  -> See vector-im/riot-web#10392

Signed-off-by: Bendodroid <bendodroid@icloud.com>
Bendodroid added a commit to Bendodroid/void-packages that referenced this pull request Oct 4, 2019
- Adjust template.
- Delete patch only needed for electron5-incompatible versions.
  -> See vector-im/riot-web#10392

Signed-off-by: Bendodroid <bendodroid@icloud.com>
Bendodroid added a commit to Bendodroid/void-packages that referenced this pull request Oct 4, 2019
- Adjust template.
- Delete patch only needed for electron5-incompatible versions.
  -> See vector-im/riot-web#10392

Signed-off-by: Bendodroid <bendodroid@icloud.com>
Hoshpak added a commit to void-linux/void-packages that referenced this pull request Oct 4, 2019
- Adjust template.
- Delete patch only needed for electron5-incompatible versions.
  -> See vector-im/riot-web#10392

Signed-off-by: Bendodroid <bendodroid@icloud.com>
bilebucket added a commit to bilebucket/void-packages that referenced this pull request Oct 22, 2019
- Adjust template.
- Delete patch only needed for electron5-incompatible versions.
  -> See vector-im/riot-web#10392

Signed-off-by: Bendodroid <bendodroid@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.