Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe our existing features better in documentation #10418

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Jul 25, 2019

No description provided.

@turt2live turt2live requested a review from vector-im/riot-web Jul 25, 2019
@@ -28,5 +45,3 @@ Once enabled, send a custom state event to a room to set values:
```

That's it. Now should see your new counter under the header.

[#riot-web:matrix.org]: https://matrix.to/#/#riot-web:matrix.org

This comment has been minimized.

Copy link
@turt2live

turt2live Jul 25, 2019

Author Member

I have a personal dislike for this style of link, so I've moved it.

@turt2live turt2live added this to In Review in Workflow Jul 25, 2019
@jryans jryans requested review from jryans and removed request for vector-im/riot-web Jul 26, 2019
@jryans
jryans approved these changes Jul 26, 2019
Copy link
Member

jryans left a comment

Looks great! 😍 Thanks for doing this. I hope we'll remember to update this in a similar way for any future features.

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Jul 26, 2019

I hope we'll remember to update this in a similar way for any future features.

I'm extremely tempted to make a CI job that scans for the string in this file when the features change in the react-sdk. For now though, let's hope our memory is sufficient ;)

@turt2live turt2live merged commit 11c0e98 into develop Jul 26, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #684 passed (2 minutes, 44 seconds)
Details
buildkite/riot-web/eslint-lint Passed (41 seconds)
Details
buildkite/riot-web/i18n Passed (1 minute, 38 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 18 seconds)
Details
buildkite/riot-web/pipeline Passed (10 seconds)
Details
Workflow automation moved this from In Review to In Test Jul 26, 2019
@turt2live turt2live deleted the travis/features branch Jul 26, 2019
@jryans jryans moved this from In Test to In RC in Workflow Aug 1, 2019
@jryans jryans moved this from In RC to Done in Workflow Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.