Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to React 16 #10480

Merged
merged 7 commits into from Sep 11, 2019

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Aug 1, 2019

Depends on matrix-org/matrix-react-sdk#3270

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Fixes #6410 ~ Travis

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy referenced this pull request Aug 1, 2019
t3chguy added 6 commits Aug 6, 2019
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@jryans jryans changed the title Switch to React 16.8 Switch to React 16 Aug 28, 2019
@t3chguy t3chguy requested a review from vector-im/riot-web Sep 6, 2019
@turt2live turt2live added this to In Review in Workflow Sep 6, 2019
@turt2live turt2live removed this from In Review in Workflow Sep 6, 2019
Copy link
Member

turt2live left a comment

lgtm however due to a significant release in the works, I think it's best to land this after the release for maximum testing time. If all goes according to plan, we'll be releasing in about a week.

@turt2live turt2live referenced this pull request Sep 6, 2019
@turt2live turt2live merged commit 0b6c29d into develop Sep 11, 2019
5 checks passed
5 checks passed
buildkite/riot-web/pr Build #836 passed (2 minutes, 48 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (56 seconds)
Details
buildkite/riot-web/pr/i18n Passed (1 minute, 55 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 37 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (9 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.