Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change integrations_widgets_urls default configuration #10656

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@jaywink
Copy link
Member

jaywink commented Aug 26, 2019

Add and prioritize the new "_matrix/integrations/v1" widget urls

As per MSC1961, add to the whitelisted integrations_widget_urls
the new paths. This allows us to switch Scalar over to use the
new path as default.

Note, the legacy "scalar-staging.riot.im" is these days just a redirect
to scalar-staging.vector.im, so there is no addition for that. It still
needs Riot side whitelisting though for existing widgets.

Refs: matrix-org/matrix-doc#1961

Provide our common integrations_widget_urls defaults for sample config

Closes: #10454

jaywink added 2 commits Aug 26, 2019
As per MSC1961, add to the whitelisted integrations_widget_urls
the new paths. This allows us to switch Scalar over to use the
new path as default.

Note, the legacy "scalar-staging.riot.im" is these days just a redirect
to scalar-staging.vector.im, so there is no addition for that. It still
needs Riot side whitelisting though for existing widgets.
@jaywink jaywink requested a review from vector-im/riot-web Aug 26, 2019
Copy link
Member

turt2live left a comment

This is fine for now, but we really should be working towards killing this setting.

@jaywink jaywink merged commit 9b7f44c into develop Aug 26, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #829 passed (5 minutes, 6 seconds)
Details
buildkite/riot-web/eslint-lint Passed (52 seconds)
Details
buildkite/riot-web/i18n Passed (1 minute, 53 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 49 seconds)
Details
buildkite/riot-web/pipeline Passed (9 seconds)
Details
@jaywink jaywink deleted the jaywink/integrations-widget-urls branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.