Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install guide #10810

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@nadonomy
Copy link
Member

nadonomy commented Sep 9, 2019

Updated styling to present options clearer and with less scrolling. Removed extraneous copy & elements. Looks like:

Screenshot 2019-09-09 at 16 37 56

& if there's server configuration:

Screenshot 2019-09-09 at 16 37 20

Not merge ready. configure_riot_button needs to be dynamically set, using whatever configuration link we arrive at. Ideally this is either a universal link for both iOS & Android, or if not we detect user agent and inject appropriately.

nadonomy and others added 4 commits Sep 9, 2019
also make button a link 'cos buttons can't have hrefs
@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented Sep 10, 2019

Made button update dynamically (I also made it a link instead as buttons can't have hrefs). Other changes look good.

@dbkr dbkr merged commit 89e9ac8 into develop Sep 10, 2019
5 checks passed
5 checks passed
buildkite/riot-web/pr Build #887 passed (2 minutes, 52 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (41 seconds)
Details
buildkite/riot-web/pr/i18n Passed (2 minutes, 5 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 39 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (9 seconds)
Details
@turt2live turt2live added this to In Test in Workflow Sep 10, 2019
@@ -92,6 +92,9 @@ async function initPage() {
if (isUrl && !isUrl.endsWith('/')) isUrl += '/';

if (hsUrl !== 'https://matrix.org/') {
document.getElementById('configure_riot_button').href =
"https://riot.im/config/config?hs_url=" + encodeURIComponent(hsUrl) +

This comment has been minimized.

Copy link
@turt2live

turt2live Sep 10, 2019

Member

configconfig?

@aaronraimist

This comment has been minimized.

Copy link
Contributor

aaronraimist commented Sep 10, 2019

"Back to Desktop"?

"Back to Riot.im" was already confusing for many users. I'm not really sure what back to desktop even means.

It would be really great to say something closer to "Use Riot in my web browser instead (not recommended)", obviously word that better if you can but back to desktop doesn't really make sense.

@nadonomy

This comment has been minimized.

Copy link
Member Author

nadonomy commented Sep 10, 2019

"Back to Desktop"?

"Back to Riot.im" was already confusing for many users. I'm not really sure what back to desktop even means.

It would be really great to say something closer to "Use Riot in my web browser instead (not recommended)", obviously word that better if you can but back to desktop doesn't really make sense.

Viewed in a vacuum on desktop, I'd agree. However, if we empathise with the journey the user has taken to arrive at this context:

  • They know the URL of a Riot instance, which means they're either (a) already a Riot web user or (b) they're a new user coming in via about.riot.im or (c) someone shared a Riot URL with them, presumably with more context.
  • They're viewing this on a mobile device (redirect by user agent)

Considering the most prevalent mobile browsers (Safari on iOS & Chrome on Android) use 'Request Desktop Site' I think it's wise to borrow affordance from their nomenclature, albeit dropping 'Site'.

@aaronraimist

This comment has been minimized.

Copy link
Contributor

aaronraimist commented Sep 10, 2019

Back to Desktop Site would be a lot clearer imo

@aaronraimist

This comment has been minimized.

Copy link
Contributor

aaronraimist commented Sep 10, 2019

Although I still don't understand why it is "Back to". They loaded riot.im in their browser and were immediately redirected to this page right? They were never on the desktop site to begin with.

@dbkr dbkr referenced this pull request Sep 11, 2019
@nadonomy

This comment has been minimized.

Copy link
Member Author

nadonomy commented Sep 11, 2019

Although I still don't understand why it is "Back to". They loaded riot.im in their browser and were immediately redirected to this page right? They were never on the desktop site to begin with.

You're right— "Go to Desktop Site" could be more appropriate, depending on their entry path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.