Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak lock file to pull in only one React version #10874

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@jryans
Copy link
Member

jryans commented Sep 16, 2019

Yarn deps can be a bit fiddly when targeting specific versions. This tweaks the
lock file to only pull in a single React version.

For others who may need to do something like this again, I recommend deleting
specific package entries from yarn.lock and re-running yarn install. That
should make it pick the right thing while also leaving other packages as they
were.

(Note that riot-web still pulls in React 15 temporarily as a side effect of depending on released versions of React SDK. This will resolved itself during the next release.)

Yarn deps can be a bit fiddly when targeting specific versions. This tweaks the
lock file to only pull in a single React version.

For others who may need to do something like this again, I recommend deleting
specific package entries from `yarn.lock` and re-running `yarn install`. That
should make it pick the right thing while also leaving other packages as they
were.
@jryans jryans requested a review from vector-im/riot-web Sep 16, 2019
@jryans jryans added this to In Review in Workflow Sep 16, 2019
@jryans jryans merged commit df7bd02 into develop Sep 16, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #923 passed (2 minutes, 52 seconds)
Details
buildkite/riot-web/eslint-lint Passed (39 seconds)
Details
buildkite/riot-web/i18n Passed (1 minute, 36 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 40 seconds)
Details
buildkite/riot-web/pipeline Passed (10 seconds)
Details
Workflow automation moved this from In Review to In Test Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.