Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to #develop and use the same gemini-scrollbar version as the react-sdk #10893

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Sep 17, 2019

See #10894 for why we're using develop. The gemini-scrollbar upgrade is just cleanliness (no material change).

It's safe to point at develop even though yarn doesn't build the dependency because we end up building the dependency when we start or build later.

Should be reviewed with matrix-org/matrix-react-sdk#3451

Might fix an issue?
@turt2live turt2live requested a review from vector-im/riot-web Sep 17, 2019
@turt2live turt2live added this to In Review in Workflow Sep 17, 2019
@turt2live turt2live changed the title Use the same gemini-scrollbar version as the react-sdk Point to #develop and use the same gemini-scrollbar version as the react-sdk Sep 17, 2019
@jryans
jryans approved these changes Sep 17, 2019
@jryans

This comment has been minimized.

Copy link
Member

jryans commented Sep 17, 2019

This one is missing the change to #develop, so I guess there's more to come here.

@turt2live turt2live requested a review from jryans Sep 17, 2019
@jryans
jryans approved these changes Sep 17, 2019
@turt2live turt2live merged commit e8fbd77 into develop Sep 17, 2019
5 checks passed
5 checks passed
buildkite/riot-web/pr Build #933 passed (2 minutes, 50 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (38 seconds)
Details
buildkite/riot-web/pr/i18n Passed (1 minute, 30 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 39 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (10 seconds)
Details
Workflow automation moved this from In Review to In Test Sep 17, 2019
@turt2live turt2live deleted the travis/bump2 branch Sep 17, 2019
@turt2live turt2live removed this from In Test in Workflow Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.