Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request persistent storage on Electron #11052

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Oct 4, 2019

It's still not 100% clear whether storage is always persistent on
Electron, but we seem to be getting reports of it being deleted in
the wild on Electron, so let's try calling the API to request
persistent storage. It won't pop up a dialog on Electron. In the
worst case it will give us some logging so we know what the API calls
return.

We could do this on non-desktop too but it's a bit of a mess because
Firefox prompts the user but Chrome makes a decision itself based on
how much the user visits the site.

It's still not 100% clear whether storage is always persistent on
Electron, but we seem to be getting reports of it being deleted in
the wild on Electron, so let's try calling the API to request
persistent storage. It won't pop up a dialog on Electron. In the
worst case it will give us some logging so we know what the API calls
return.

We could do this on non-desktop too but it's a bit of a mess because
Firefox prompts the user but Chrome makes a decision itself based on
how much the user visits the site.
@dbkr dbkr requested a review from vector-im/riot-web Oct 4, 2019
Copy link
Contributor

bwindels left a comment

lgtm

@dbkr dbkr merged commit 9981f89 into develop Oct 4, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1047 passed (2 minutes, 46 seconds)
Details
buildkite/riot-web/eslint-lint Passed (1 minute)
Details
buildkite/riot-web/i18n Passed (2 minutes, 21 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 42 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.