Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notarise the macOS app #11119

Merged
merged 8 commits into from Oct 11, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Oct 11, 2019

Notarise the mac app in the electron build process

dbkr added 8 commits Oct 9, 2019
...before we start the build process.
It doesn't work as a github dependency because the typescript
doesn't get built.
@dbkr dbkr requested a review from vector-im/riot-web Oct 11, 2019
Copy link
Contributor

bwindels left a comment

lgtm!

// We get the password from keychain. The keychain stores
// user IDs too, but apparently altool can't get the user ID
// from the keychain, so we need to get it from the environment.
const userId = process.env.NOTARIZE_APPLE_ID;

This comment has been minimized.

Copy link
@jryans

jryans Oct 11, 2019

Member

Who will set this env var? Can we manually extract it from keychain with keychain find-generic-password ... or similar?

This comment has been minimized.

Copy link
@dbkr

dbkr Oct 11, 2019

Author Member

I was just going to put it in the ~/.profile on the build machine. I'd hoped we'd be be able to just get it out of the keychain but I can't work out how to get the entry in a place in the keychain where both altool and security can find it...

This comment has been minimized.

Copy link
@jryans

jryans Oct 11, 2019

Member

Aha, I see... Well, probably it's fine. 😄

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Oct 11, 2019

(@dbkr can haz a title that will look okay in the changelog please?)

@dbkr dbkr changed the title Dbkr/notarise Notarise the macOS app Oct 11, 2019
@dbkr dbkr merged commit 21ea6c6 into develop Oct 11, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1103 passed (3 minutes, 26 seconds)
Details
buildkite/riot-web/eslint-lint Passed (57 seconds)
Details
buildkite/riot-web/i18n Passed (3 minutes, 9 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 16 seconds)
Details
buildkite/riot-web/pipeline Passed (4 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.