Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign main Windows executable #11126

Merged
merged 5 commits into from Oct 18, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Oct 11, 2019

and automate signing of installers

Apologies that I have given up on trying to make this work with proper escaping and files with spaces in the names.

dbkr added 3 commits Oct 11, 2019
and automate the signing of the installers
also don't print the signing command line as it has the token password
Almost certainly won't work for cert names with spaces in them
@dbkr dbkr requested a review from vector-im/riot-web Oct 11, 2019
@turt2live turt2live requested review from turt2live and removed request for vector-im/riot-web Oct 18, 2019
Copy link
Member

turt2live left a comment

looks like a bunch of signing code to me

electron_app/riot.im/env.sh Outdated Show resolved Hide resolved
scripts/electron-package.sh Outdated Show resolved Hide resolved
dbkr and others added 2 commits Oct 18, 2019
typo
Co-Authored-By: Travis Ralston <travpc@gmail.com>
@dbkr dbkr requested a review from turt2live Oct 18, 2019
Copy link
Member

turt2live left a comment

mhmm.. that's some code that does a thing.

I trust you've tested it and know what you're doing. There's nothing that screams del C:\ so yay

@dbkr dbkr merged commit 8e81685 into develop Oct 18, 2019
5 checks passed
5 checks passed
buildkite/riot-web/pr Build #1119 passed (3 minutes, 30 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (40 seconds)
Details
buildkite/riot-web/pr/i18n Passed (2 minutes, 11 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (3 minutes, 25 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (3 seconds)
Details
@jryans jryans added this to In RC in Workflow Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
2 participants
You can’t perform that action at this time.