Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darkModeSupport to allow dark themed title bar. #11140

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@vverst
Copy link
Contributor

vverst commented Oct 14, 2019

Adding "darkModeSupport": true to the configuration adds an item to the Info.plist in the Mac app which allows the titlebar of Riot to change with the System theme (light, dark).

In electron-builder:

    if (this.platformSpecificBuildOptions.darkModeSupport) {
      appPlist.NSRequiresAquaSystemAppearance = false
    }

Source: https://github.com/electron-userland/electron-builder/blob/faba9e365a0a4d2402d91ca9bd5a5288cb78f0f7/packages/app-builder-lib/src/macPackager.ts#L313-315

Electron info: https://electronjs.org/docs/tutorial/mojave-dark-mode-guide

Before:
riot-before

After:
riot-after

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Oct 14, 2019

Please read the contributing guide: https://github.com/vector-im/riot-web/blob/develop/CONTRIBUTING.rst

Needs sign off

@vverst

This comment has been minimized.

Copy link
Contributor Author

vverst commented Oct 14, 2019

Signed-off-by: Victor Verstappen <vpl@vpl.me>

Did not realise that it also applied to configuration files since it doesn't seem like a licensable contribution.

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Oct 14, 2019

Looks awesome, thanks for your contribution

Related to #8394

@t3chguy t3chguy merged commit 5e78312 into vector-im:develop Oct 14, 2019
@vverst vverst deleted the vverst:dark-title-bar branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.