Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Windows signing and macOS notarization to release #11158

Merged
merged 14 commits into from Oct 18, 2019

Conversation

@jryans
Copy link
Member

jryans commented Oct 18, 2019

#11126 to release.

dbkr and others added 14 commits Oct 9, 2019
...before we start the build process.
It doesn't work as a github dependency because the typescript
doesn't get built.
and automate the signing of the installers
also don't print the signing command line as it has the token password
Almost certainly won't work for cert names with spaces in them
typo
Co-Authored-By: Travis Ralston <travpc@gmail.com>
@jryans jryans merged commit 748513a into release-v1.5.0 Oct 18, 2019
1 of 5 checks passed
1 of 5 checks passed
buildkite/riot-web Build #1121 started
Details
buildkite/riot-web/eslint-lint Started...
Details
buildkite/riot-web/i18n Started...
Details
buildkite/riot-web/karma-tests Started...
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
@jryans jryans changed the title Port Windows signing to release Port Windows signing and macOS notarization to release Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.