Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of CI scripts from docs #11257

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@jryans
Copy link
Member

jryans commented Oct 29, 2019

This removes fetch-develop.deps.sh from the docs, as it's designed more for
use on CI environments and ends up causing confusion when used for anything
else.

Fixes #11247

This removes `fetch-develop.deps.sh` from the docs, as it's designed more for
use on CI environments and ends up causing confusion when used for anything
else.

Fixes #11247
@jryans jryans requested a review from vector-im/riot-web Oct 29, 2019
@jryans

This comment has been minimized.

Copy link
Member Author

jryans commented Oct 29, 2019

There was some discussion on the issue of also renaming the script to make it clear it's for CI... but I am not really sure what naming would suffice, so I haven't done that here.

Copy link
Member

turt2live left a comment

If we were to pick a new name, I'd vote for ci-fetch-deps.sh

@jryans jryans merged commit ddf733a into develop Oct 29, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1159 passed (5 minutes, 38 seconds)
Details
buildkite/riot-web/eslint-lint Passed (1 minute, 2 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 12 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 31 seconds)
Details
buildkite/riot-web/pipeline Passed (4 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.