Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-signing labs flag to develop and document #11408

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@jryans
Copy link
Member

jryans commented Nov 18, 2019

Part of #11407

@jryans jryans requested a review from vector-im/riot-web Nov 18, 2019
## Cross-signing (`feature_cross_signing`)

Cross-signing ([MSC1756](https://github.com/matrix-org/matrix-doc/pull/1756))
improves the device verification experience by allowing you to verify a user

This comment has been minimized.

Copy link
@turt2live

turt2live Nov 18, 2019

Member

minor nit: we should probably humanize this doc a bit.

This comment has been minimized.

Copy link
@jryans

jryans Nov 18, 2019

Author Member

Yeah... I haven't been sure what the doc's goal is entirely I guess... Do we want to offer a very quick setting name to one sentence summary for very slightly more understanding, or is it meant to properly explain the feature?

If it's meant to properly explain the feature, then maybe it should live somewhere else so that we don't just delete the documentation when the flag goes away.

Many similar sounding questions ensue...

This comment has been minimized.

Copy link
@turt2live

turt2live Nov 18, 2019

Member

I believe it was originally added as a way for riot admins to know what the flags are so they can pick and choose which ones they want. In practice I think it's become a bunch of helpful headers (feature name + flag) with some not-as-helpful longer form text. Maybe we just convert it to a list?

I do see some value in having a description here, but I'm not sure what the description should be. It definitely shouldn't be an exhaustive description of the feature because that's best served elsewhere (such as in user guides we don't have). It could be a high level overview of what to expect by turning it on?

This comment has been minimized.

Copy link
@jryans

jryans Nov 18, 2019

Author Member

Hmm yeah, some small description does seem helpful to have outside of the app UI for configuration, archaeology, etc. but also unsure of the right balance.

Added a retro item for this; I'll merge this text for now.

Copy link
Member

turt2live left a comment

this side lgtm

@jryans jryans merged commit fe6006f into develop Nov 18, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1307 passed (3 minutes, 19 seconds)
Details
buildkite/riot-web/eslint-lint Passed (42 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 18 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 9 seconds)
Details
buildkite/riot-web/pipeline Passed (5 seconds)
Details
@jryans

This comment has been minimized.

Copy link
Member Author

jryans commented Nov 18, 2019

Config deployed to develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.