Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign all of the Windows executable files #11516

Merged
merged 1 commit into from Nov 26, 2019
Merged

Conversation

@dbkr
Copy link
Member

dbkr commented Nov 26, 2019

We can actually just supply a custom signing module here to do our
signing rather than manually signing things in the afterSign hook.
This means all 4 executable files get signed (the main exe, the
stub exe, Update.exe and the installer).

We can actually just supply a custom signing module here to do our
signing rather than manually signing things in the afterSign hook.
This means all 4 executable files get signed (the main exe, the
stub exe, Update.exe and the installer).
@dbkr dbkr requested a review from vector-im/riot-web Nov 26, 2019
@jryans jryans requested review from jryans and removed request for vector-im/riot-web Nov 26, 2019
@jryans
jryans approved these changes Nov 26, 2019
Copy link
Member

jryans left a comment

Looks reasonable to me, and appears to handle the nested signing with two hashes.

@jryans jryans added this to In Review in Workflow Nov 26, 2019
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Nov 26, 2019

(giving this the honorary fire label to assist in urgency)

@dbkr dbkr merged commit daacd90 into develop Nov 26, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1402 passed (4 minutes, 6 seconds)
Details
buildkite/riot-web/eslint-lint Passed (54 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 34 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 53 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
Workflow automation moved this from In Review to In Test Nov 26, 2019
@turt2live turt2live moved this from In Test to In RC in Workflow Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
3 participants
You can’t perform that action at this time.