Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Sign all of the Windows executable files #11516
We can actually just supply a custom signing module here to do our signing rather than manually signing things in the afterSign hook. This means all 4 executable files get signed (the main exe, the stub exe, Update.exe and the installer).
dbkr merged commit
Nov 26, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1402 passed (4 minutes, 6 seconds)Details
buildkite/riot-web/eslint-lint Passed (54 seconds)Details
buildkite/riot-web/i18n Passed (2 minutes, 34 seconds)Details
buildkite/riot-web/karma-tests Passed (3 minutes, 53 seconds)Details
buildkite/riot-web/pipeline Passed (3 seconds)Details
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.