Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of vector.im as default identity server on mobile guide #11544

Merged

Conversation

@aaronraimist
Copy link
Collaborator

aaronraimist commented Nov 28, 2019

Fixes #11543

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@turt2live turt2live requested review from vector-im/riot-web and nadonomy Nov 28, 2019
@nadonomy

This comment has been minimized.

Copy link
Member

nadonomy commented Nov 28, 2019

@aaronraimist can you add screenshots to this PR please to make it easier to review? Thanks!

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Nov 28, 2019

@nadonomy there's not much to screenshot, it's removing the identity server from the case mentioned in this comment: #11543 (comment)

Copy link
Member

nadonomy left a comment

Gotcha, in that case then all good.

Even though the change is trivial, the screenshot aids context massively for folk (in this case, me!) jumping in from different contexts, rather than having to guess or check out what line 336 in a random file was doing.

LGTM visually, but will let yourself @turt2live approve/merge in case you have other requests.

Copy link
Member

turt2live left a comment

Code lgtm, waiting on the CI to be happy

@turt2live turt2live merged commit 86b6123 into vector-im:develop Nov 28, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1438 passed (3 minutes, 29 seconds)
Details
buildkite/riot-web/eslint-lint Passed (59 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 18 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 18 seconds)
Details
buildkite/riot-web/pipeline Passed (4 seconds)
Details
@aaronraimist aaronraimist deleted the aaronraimist:mobile-guide-no-default-is branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.