Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker build for develop and publish a /version file #11588

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Dec 3, 2019

Fixes #10426

The problem with the docker image for develop was that the dependencies pointing at develop are empirically not working - it's pulling in the latest release still even though we are saying to use the develop branch. To fix this, we just pull in develop by default if we're building develop.

@turt2live turt2live requested a review from vector-im/riot-web Dec 3, 2019
@jryans
jryans approved these changes Dec 3, 2019
Dockerfile Show resolved Hide resolved
@turt2live turt2live merged commit 19c1ded into develop Dec 3, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1450 passed (3 minutes, 4 seconds)
Details
buildkite/riot-web/eslint-lint Passed (38 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 14 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
@turt2live turt2live deleted the travis/docker-versions branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.