Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more languages #11592

Merged
merged 2 commits into from Dec 3, 2019
Merged

Enable more languages #11592

merged 2 commits into from Dec 3, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Dec 3, 2019

Enabled (riot-web % / react-sdk %):

  • Lithuanian: 100% / 48.1% translated
  • Hindi: 69.6% / 36.5% translated
  • Ukrainian: 100% / 28.5% translated
  • Icelandic: 43.5% / 27.7% translated

They aren't the highest languages, but they are more than our lowest translated & enabled languages.

Enabled (riot-web % / react-sdk %):
* Lithuanian: 100% / 48.1% translated
* Hindi: 69.6% / 36.5% translated
* Ukrainian: 100% / 28.5% translated
* Icelandic: 43.5% / 27.7% translated

They aren't the highest languages, but they are more than our lowest translated & enabled languages.
@turt2live turt2live requested a review from vector-im/riot-web Dec 3, 2019
@turt2live turt2live added this to In Review in Workflow Dec 3, 2019
@t3chguy
t3chguy approved these changes Dec 3, 2019
Copy link
Member

jryans left a comment

I am not a speaker of any of these languages, so I have no idea what the correct spellings are, and I am curious what your source is.

I've found the "native name" column of the ISO code table to be a decent source in the past.

scripts/copy-res.js Outdated Show resolved Hide resolved
scripts/copy-res.js Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from jryans Dec 3, 2019
@jryans
jryans approved these changes Dec 3, 2019
Copy link
Member

jryans left a comment

Yay, thanks! 😁

@turt2live turt2live merged commit ea1ed19 into develop Dec 3, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1460 passed (3 minutes, 35 seconds)
Details
buildkite/riot-web/eslint-lint Passed (50 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 8 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 25 seconds)
Details
buildkite/riot-web/pipeline Passed (4 seconds)
Details
Workflow automation moved this from In Review to In Test Dec 3, 2019
@turt2live turt2live deleted the travis/more-language branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.