Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the webpack config work for us #11712

Merged
merged 5 commits into from Jan 9, 2020
Merged

Conversation

@turt2live
Copy link
Member

turt2live commented Dec 24, 2019

This is against travis/sourcemaps for safety.

Split from #11679

This moves the babel and postcss configs into the webpack config for ease of maintenance (and because we need variations of them). The typescript config is left outside the webpack config for IDEs to pick it up.

Other changes regarding the config should be documented in the diff itself.


This PR and others in the series have their overview covered here: https://gist.github.com/turt2live/a3fc7c9712b8ef0f1f758611aa33382d

This moves the babel and postcss configs into the webpack config for ease of maintenance (and because we need variations of them). The typescript config is left outside the webpack config for IDEs to pick it up.
@turt2live turt2live requested a review from vector-im/riot-web Dec 24, 2019
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Dec 24, 2019

Build failures at this point are expected - they'll be fixed in a future PR before going to develop.

@turt2live turt2live added this to In Review in Workflow Dec 24, 2019
@turt2live turt2live removed this from In Review in Workflow Jan 7, 2020
tsconfig.json Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented Jan 8, 2020

lgtm with those 2 comments and ideally whittling down the extensions list a little.

@turt2live turt2live requested a review from dbkr Jan 8, 2020
For reasons described within this diff.
@dbkr
dbkr approved these changes Jan 9, 2020
Copy link
Member

dbkr left a comment

Thanks - this will almost certainly lead to a less confused me in 2 months time, if nobody else :)

@turt2live turt2live merged commit 929096b into travis/sourcemaps Jan 9, 2020
3 of 5 checks passed
3 of 5 checks passed
buildkite/riot-web Build #1627 failed (3 minutes, 24 seconds)
Details
buildkite/riot-web/karma-tests Failed (exit status 1)
Details
buildkite/riot-web/eslint-lint Passed (44 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 7 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
@turt2live turt2live deleted the travis/babel7-wp-wp branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.