Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build scripts for new process #11801

Merged
merged 8 commits into from Jan 9, 2020
Merged

Conversation

@turt2live
Copy link
Member

turt2live commented Jan 8, 2020

This is against travis/sourcemaps for safety.

Note: we needed to convert something to TypeScript so it doesn't complain that there's nothing to compile, so the smallest utility file was chosen.

This is based on #11712 - see pull/11712/head...pull/11801/head for the real diff

Many of the script changes (including linters) are pulled in from the react-sdk.

turt2live added 8 commits Dec 24, 2019
This moves the babel and postcss configs into the webpack config for ease of maintenance (and because we need variations of them). The typescript config is left outside the webpack config for IDEs to pick it up.
For reasons described within this diff.
We have to convert *something* to TypeScript so it doesn't complain that there's nothing to compile, so this converts the easiest utility library.

Many of the scripts are copied from the react-sdk.
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Jan 8, 2020

A failing build isn't terribly surprising for this PR - 2/3rds of the dependencies are missing/not mapped.

@turt2live turt2live requested a review from vector-im/riot-web Jan 8, 2020
@dbkr
dbkr approved these changes Jan 9, 2020
@turt2live turt2live merged commit a91bab2 into travis/sourcemaps Jan 9, 2020
3 of 7 checks passed
3 of 7 checks passed
buildkite/riot-web Build #1629 failed (2 minutes, 59 seconds)
Details
buildkite/riot-web/build Failed (exit status 1)
Details
buildkite/riot-web/eslint-js-lint Failed (exit status 1)
Details
buildkite/riot-web/karma-tests Failed (exit status 1)
Details
buildkite/riot-web/eslint-types-lint Passed (46 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 3 seconds)
Details
buildkite/riot-web/pipeline Passed (6 seconds)
Details
@turt2live turt2live deleted the travis/babel7-wp-scripts branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.