Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support application/wasm in Docker image #11858

Merged
merged 2 commits into from Jan 15, 2020
Merged

Support application/wasm in Docker image #11858

merged 2 commits into from Jan 15, 2020

Conversation

@Half-Shot
Copy link
Contributor

Half-Shot commented Jan 15, 2020

Fixes #11857

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Jan 15, 2020

The branch changes seem unrelated, whats the justification for them?

@t3chguy t3chguy requested a review from vector-im/riot-web Jan 15, 2020
@Half-Shot

This comment has been minimized.

Copy link
Contributor Author

Half-Shot commented Jan 15, 2020

The branch changes seem unrelated, whats the justification for them?

Me being an idiot and committing them :)

Signed-off-by: Half-Shot <will@half-shot.uk>
@Half-Shot Half-Shot force-pushed the hs/wasm-docker branch from ebf981e to d515bad Jan 15, 2020
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@Half-Shot Half-Shot requested a review from turt2live Jan 15, 2020
Copy link
Member

turt2live left a comment

I trust that the sed thing is reasonable

@Half-Shot Half-Shot merged commit 044720b into develop Jan 15, 2020
5 checks passed
5 checks passed
buildkite/riot-web Build #1681 passed (4 minutes, 8 seconds)
Details
buildkite/riot-web/eslint-lint Passed (2 minutes, 43 seconds)
Details
buildkite/riot-web/i18n Passed (3 minutes, 23 seconds)
Details
buildkite/riot-web/karma-tests Passed (4 minutes, 1 second)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
@Half-Shot Half-Shot deleted the hs/wasm-docker branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.