Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jest for tests #11869

Merged
merged 12 commits into from Jan 16, 2020
Merged

Use Jest for tests #11869

merged 12 commits into from Jan 16, 2020

Conversation

@turt2live
Copy link
Member

turt2live commented Jan 15, 2020

Fixes #11291

See commits for a bit of a story to how we got here.

There's a couple things of note that aren't recorded in the diff very well:

  • We bring in canvas for the COLR checks to pass (and upgrade our jsdom environment to pull it in correctly).
  • We use a fake indexeddb so we can do indexeddb things.
  • We have to map some modules to things to fix i18n, the number of copies of react we're running, etc
  • The tests take about 166 seconds to run on my machine (i9-9900k, many RAM) - they surely take longer on CI.
@turt2live turt2live requested a review from vector-im/riot-web Jan 15, 2020
Copy link
Collaborator

t3chguy left a comment

LGTM otherwise

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
test/app-tests/loading-test.js Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from t3chguy Jan 15, 2020
@turt2live turt2live merged commit 2652060 into develop Jan 16, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #1692 passed (4 minutes, 49 seconds)
Details
buildkite/riot-web/build Passed (4 minutes, 39 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (1 minute)
Details
buildkite/riot-web/eslint-types-lint Passed (54 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 52 seconds)
Details
buildkite/riot-web/jest-tests Passed (3 minutes, 19 seconds)
Details
buildkite/riot-web/pipeline Passed (4 seconds)
Details
@turt2live turt2live deleted the travis/jest branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.