Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rageshake post-sourcemaps #11926

Merged
merged 1 commit into from Jan 18, 2020
Merged

Fix rageshake post-sourcemaps #11926

merged 1 commit into from Jan 18, 2020

Conversation

@turt2live
Copy link
Member

turt2live commented Jan 18, 2020

Error was "s is not a function" because of how require works.

@turt2live turt2live requested a review from vector-im/riot-web Jan 18, 2020
@turt2live turt2live added this to In Review in Workflow Jan 18, 2020
@turt2live turt2live merged commit 342d717 into develop Jan 18, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #1727 passed (6 minutes, 52 seconds)
Details
buildkite/riot-web/build Passed (5 minutes, 42 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (59 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (1 minute, 1 second)
Details
buildkite/riot-web/i18n Passed (2 minutes, 58 seconds)
Details
buildkite/riot-web/jest-tests Passed (4 minutes, 21 seconds)
Details
buildkite/riot-web/pipeline Passed (7 seconds)
Details
Workflow automation moved this from In Review to In Test Jan 18, 2020
@turt2live turt2live deleted the travis/fix-rageshake branch Jan 18, 2020
@bwindels

This comment has been minimized.

Copy link
Contributor

bwindels commented Jan 20, 2020

I've encountered this issue just now, using riot-web version: 342d717-react-a984f9acf3e1-js-dba08d230e42 which seems to include the fix already.

@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 20, 2020

Looks like the BugReportDialog needs similar treatment, working on it in #11938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.