Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load as little as possible in index.js for the skinner #11959

Merged
merged 1 commit into from Jan 21, 2020

Conversation

@turt2live
Copy link
Member

turt2live commented Jan 21, 2020

Imports are optimized to be concurrent/async by webpack, which means that when the old index.js referenced the Lifecycle from the react-sdk it caused the app to explode. This is because in another branch the Lifecycle references a class member of a skinnable component, leading to the skinner complaining that the skin hasn't been loaded.

To work around this, we've shoved all the app stuff to a new app.js file, leaving just the skinning and some early bootstrap work in the index.js

For #11871

Imports are optimized to be concurrent/async by webpack, which means that when the old index.js referenced the Lifecycle from the react-sdk it caused the app to explode. This is because in another branch the Lifecycle references a class member of a skinnable component, leading to the skinner complaining that the skin hasn't been loaded.

To work around this, we've shoved all the app stuff to a new app.js file, leaving just the skinning and some early bootstrap work in the index.js
@turt2live turt2live requested a review from vector-im/riot-web Jan 21, 2020
@turt2live turt2live added this to In Review in Workflow Jan 21, 2020
@turt2live turt2live added the p2 label Jan 21, 2020
@turt2live turt2live merged commit 3036bab into develop Jan 21, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #1753 passed (5 minutes, 43 seconds)
Details
buildkite/riot-web/build Passed (5 minutes, 38 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (1 minute, 7 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (1 minute, 17 seconds)
Details
buildkite/riot-web/i18n Passed (3 minutes, 37 seconds)
Details
buildkite/riot-web/jest-tests Passed (4 minutes, 41 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
Workflow automation moved this from In Review to In Test Jan 21, 2020
@turt2live turt2live deleted the travis/fix-skinning branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.