Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bash in Docker scripts #12001

Merged
merged 1 commit into from Jan 22, 2020
Merged

Use bash in Docker scripts #12001

merged 1 commit into from Jan 22, 2020

Conversation

@jryans
Copy link
Member

jryans commented Jan 22, 2020

Our Docker scripts use Bash-style conditionals that aren't supported by the
default Debian shell.

As a result, we weren't calculating the right branches for the SDKs on develop.

Our Docker scripts use Bash-style conditionals that aren't supported by the
default Debian shell.
@jryans jryans requested a review from vector-im/riot-web Jan 22, 2020
Copy link
Member

turt2live left a comment

I believe you

@jryans jryans merged commit d7e4784 into develop Jan 22, 2020
3 of 7 checks passed
3 of 7 checks passed
buildkite/riot-web Build #1785 started
Details
buildkite/riot-web/build Started...
Details
buildkite/riot-web/i18n Started...
Details
buildkite/riot-web/jest-tests Started...
Details
buildkite/riot-web/eslint-js-lint Passed (58 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (1 minute, 5 seconds)
Details
buildkite/riot-web/pipeline Passed (7 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.