Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel targets #12102

Merged
merged 3 commits into from Jan 28, 2020
Merged

Update babel targets #12102

merged 3 commits into from Jan 28, 2020

Conversation

@turt2live
Copy link
Member

turt2live commented Jan 28, 2020

@turt2live turt2live requested a review from vector-im/riot-web Jan 28, 2020
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Jan 28, 2020

I don't know why the riot tests blew up here

@jryans jryans requested review from jryans and removed request for vector-im/riot-web Jan 28, 2020
@jryans
jryans approved these changes Jan 28, 2020
Copy link
Member

jryans left a comment

Thanks for working on this! 😁

babel.config.js Outdated Show resolved Hide resolved
@jryans jryans added this to In Review in Workflow Jan 28, 2020
Copy link
Member

dbkr left a comment

otherwise looks sensible

babel.config.js Outdated Show resolved Hide resolved
babel.config.js Outdated Show resolved Hide resolved
turt2live added 2 commits Jan 28, 2020
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Jan 28, 2020

Tests failing due to #12109 as far as I can tell.

@turt2live turt2live merged commit daf6aaa into develop Jan 28, 2020
5 of 7 checks passed
5 of 7 checks passed
buildkite/riot-web Build #1858 failed (6 minutes, 24 seconds)
Details
buildkite/riot-web/jest-tests Failed (exit status 1)
Details
buildkite/riot-web/build Passed (6 minutes, 13 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (3 minutes, 42 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (1 minute, 21 seconds)
Details
buildkite/riot-web/i18n Passed (3 minutes, 35 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
Workflow automation moved this from In Review to In Test Jan 28, 2020
@turt2live turt2live deleted the travis/babel-skinning branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.