Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Browser checks #12232

Merged
merged 5 commits into from Feb 5, 2020
Merged

Improve Browser checks #12232

merged 5 commits into from Feb 5, 2020

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Feb 4, 2020

Fixes #12195

  • Updates vendored Modernizr
  • Moves Modernizr dep to dev-dep as we use vendored one and only dev-script needs the node_modules one.
  • Adds custom tests for Object.fromEntries and Promise.prototype.finally
  • Adds extra modernizr rules to make issues like #10126 more understandable
src/vector/app.js Outdated Show resolved Hide resolved
@jryans
jryans approved these changes Feb 4, 2020
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Feb 4, 2020

image

@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Feb 5, 2020

image

@t3chguy t3chguy marked this pull request as ready for review Feb 5, 2020
@t3chguy t3chguy requested a review from jryans Feb 5, 2020
@jryans
jryans approved these changes Feb 5, 2020
Copy link
Member

jryans left a comment

Looks great, thanks for working on this! 😁

@t3chguy t3chguy merged commit f7e5613 into develop Feb 5, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #1943 passed (6 minutes, 30 seconds)
Details
buildkite/riot-web/build Passed (6 minutes, 19 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (3 minutes, 55 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (1 minute, 4 seconds)
Details
buildkite/riot-web/i18n Passed (4 minutes, 23 seconds)
Details
buildkite/riot-web/jest-tests Passed (4 minutes, 44 seconds)
Details
buildkite/riot-web/pipeline Passed (6 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.