Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribute.json #12251

Merged
merged 2 commits into from Feb 5, 2020
Merged

Add contribute.json #12251

merged 2 commits into from Feb 5, 2020

Conversation

@jaywink
Copy link
Member

jaywink commented Feb 5, 2020

This document is required for example for all Mozilla websites.
Might make sense for Riot sites to also describe themselves?

See: https://www.contributejson.org/

Signed-off-by: Jason Robinson jasonr@matrix.org

This document is required for example for all Mozilla websites
and makes sense for Riot to also describe itself - see
https://www.contributejson.org/

Signed-off-by: Jason Robinson <jasonr@matrix.org>
@jaywink jaywink requested a review from vector-im/riot-web Feb 5, 2020
@@ -0,0 +1,17 @@
{

This comment has been minimized.

Copy link
@turt2live

turt2live Feb 5, 2020

Member

According to the docs it should be at the project root?

This comment has been minimized.

Copy link
@jaywink

jaywink Feb 5, 2020

Author Member

It's copied into webapp in the build here and as such is in the same place as config.json if I've understood the build process correctly?

This comment has been minimized.

Copy link
@turt2live

turt2live Feb 5, 2020

Member

This is more what I'm referencing:
image

This comment has been minimized.

Copy link
@turt2live

turt2live Feb 5, 2020

Member

the build tools can pull from there too, though it'll also need adding to the files in the package.json

This comment has been minimized.

Copy link
@jaywink

jaywink Feb 5, 2020

Author Member

This is more what I'm referencing:
image

Ah right, you're referring to how it's deployed on riot.im/app for example. True, this wont work on the NV maintained riot web's at all. I guess the idea was not so much the NV installed riot but any hosted riot on a root path of their domain.

This comment has been minimized.

Copy link
@jaywink

jaywink Feb 5, 2020

Author Member

the build tools can pull from there too, though it'll also need adding to the files in the package.json

res is already in files - will that do? I verified yarn build does end up copying the file, but if it's needed explicitly somewhere else can add.

This comment has been minimized.

Copy link
@turt2live

turt2live Feb 5, 2020

Member

The problem has nothing to do with the build process: I literally mean move this file up one directory.

This comment has been minimized.

Copy link
@jaywink

jaywink Feb 5, 2020

Author Member

Sorry, I seriously have had enough coffee but somehow managed to totally misunderstand everything you clearly wrote while juggling other things. Fixed now.

This comment has been minimized.

Copy link
@turt2live

turt2live Feb 5, 2020

Member

No worries, thanks!

@turt2live turt2live added this to In Review in Workflow Feb 5, 2020
Signed-off-by: Jason Robinson <jasonr@matrix.org>
@turt2live turt2live self-requested a review Feb 5, 2020
Copy link
Member

turt2live left a comment

seems like a thing we should have. If people disagree, they should speak up.

@turt2live turt2live merged commit b107da0 into develop Feb 5, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #1945 passed (8 minutes, 32 seconds)
Details
buildkite/riot-web/build Passed (5 minutes, 50 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (3 minutes, 56 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (57 seconds)
Details
buildkite/riot-web/i18n Passed (4 minutes)
Details
buildkite/riot-web/jest-tests Passed (8 minutes, 24 seconds)
Details
buildkite/riot-web/pipeline Passed (6 seconds)
Details
Workflow automation moved this from In Review to In Test Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.