Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax macOS notarisation check to print a warning #12503

Merged
merged 2 commits into from Feb 25, 2020

Conversation

@jryans
Copy link
Member

jryans commented Feb 25, 2020

This makes it a bit more friendly to build macOS Electron builds without a
notarisation config set up by only warning when it is missing.

This makes it a bit more friendly to build macOS Electron builds without a
notarisation config set up by only warning when it is missing.
@jryans jryans requested a review from vector-im/riot-web Feb 25, 2020
Copy link
Collaborator

t3chguy left a comment

I'd argue this should be visually noisier, maybe a banner style thing to ensure it is noticed by the user, in case of them making a mistake in their setup

@jryans jryans requested a review from t3chguy Feb 25, 2020
@jryans jryans merged commit 81578fc into develop Feb 25, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #2080 passed (5 minutes, 30 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (3 minutes, 56 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (55 seconds)
Details
buildkite/riot-web/globe-with-meridians-i18n Passed (3 minutes, 17 seconds)
Details
buildkite/riot-web/hammer-and-wrench-build Passed (5 minutes, 21 seconds)
Details
buildkite/riot-web/jest-tests Passed (4 minutes, 19 seconds)
Details
buildkite/riot-web/pipeline Passed (5 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.