Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch out any eval-using Modernizr rules #12519

Merged
merged 1 commit into from Feb 26, 2020
Merged

Switch out any eval-using Modernizr rules #12519

merged 1 commit into from Feb 26, 2020

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Feb 26, 2020

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Switches out es5/specification into its child rules, with the exception of es5array as we already check es6array and es5syntax because it required eval which caused the RED SCREEN OF DEATH for firefox users which have eval disabled and get away with it because WASM is special.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from vector-im/riot-web Feb 26, 2020
@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Feb 26, 2020

Based on http://kangax.github.io/compat-table/es5/ it is safe to assume everything we care about would pass es5syntax anyway.

@t3chguy t3chguy added this to In Review in Workflow Feb 26, 2020
@t3chguy t3chguy merged commit 4916ed0 into develop Feb 26, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #2095 passed (6 minutes, 19 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (3 minutes, 48 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (1 minute, 3 seconds)
Details
buildkite/riot-web/globe-with-meridians-i18n Passed (3 minutes, 16 seconds)
Details
buildkite/riot-web/hammer-and-wrench-build Passed (6 minutes, 3 seconds)
Details
buildkite/riot-web/jest-tests Passed (4 minutes, 35 seconds)
Details
buildkite/riot-web/pipeline Passed (6 seconds)
Details
Workflow automation moved this from In Review to In Test Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.