Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.html: Place noscript on top of the page #12563

Merged
merged 2 commits into from Feb 28, 2020

Conversation

@krkk
Copy link
Contributor

krkk commented Feb 28, 2020

Before this change, you had to scroll down to see the noscript element.
This change places the noscript element on top of the page making sure that a user will see this message when site is loaded without JavaScript.

Related: #178

krkk and others added 2 commits Feb 22, 2020
Before this change, you had to scroll down to see the noscript element.
This change places the noscript element on top of the page making sure
that a user will see this message when site is loaded without JavaScript.

Signed-off-by: Karol Kosek <krkk@krkk.ct8.pl>
@turt2live turt2live self-requested a review Feb 28, 2020
@turt2live turt2live added this to In Review in Workflow Feb 28, 2020
Copy link
Member

turt2live left a comment

Thanks! This looks fine, assuming the CI passes. I've merged in latest develop as it appears to have been based off an older develop branch, and the tests weren't happy about that.

@turt2live turt2live merged commit 0e37aa9 into vector-im:develop Feb 28, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #2136 passed (5 minutes, 49 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (3 minutes, 25 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (56 seconds)
Details
buildkite/riot-web/globe-with-meridians-i18n Passed (3 minutes, 10 seconds)
Details
buildkite/riot-web/hammer-and-wrench-build Passed (5 minutes, 40 seconds)
Details
buildkite/riot-web/jest-tests Passed (4 minutes, 30 seconds)
Details
buildkite/riot-web/pipeline Passed (6 seconds)
Details
Workflow automation moved this from In Review to In Test Feb 28, 2020
@krkk krkk deleted the krkk:noscript branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.