Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: optimize custom sdk builds #12612

Merged
merged 1 commit into from Mar 5, 2020
Merged

Conversation

@Pestdoktor
Copy link
Contributor

Pestdoktor commented Mar 4, 2020

download required branch only

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Mar 4, 2020

@Pestdoktor can we get sign off on this please? Just need to leave a comment with the following:

Signed-off-by: Your Name <email@example.org>
@turt2live turt2live requested a review from vector-im/riot-web Mar 4, 2020
@turt2live turt2live added this to In Review in Workflow Mar 4, 2020
@Pestdoktor

This comment has been minimized.

Copy link
Contributor Author

Pestdoktor commented Mar 5, 2020

Signed-off-by: Jonas Fentker <jonas@fentker.eu>

I should stick a post-it to my screen so I don't forget :D

Copy link
Member

turt2live left a comment

looks like it probably does the right thing. Thanks!

@turt2live turt2live merged commit 71f2f0e into vector-im:develop Mar 5, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #2176 passed (6 minutes, 30 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (4 minutes)
Details
buildkite/riot-web/eslint-types-lint Passed (58 seconds)
Details
buildkite/riot-web/globe-with-meridians-i18n Passed (3 minutes, 17 seconds)
Details
buildkite/riot-web/hammer-and-wrench-build Passed (6 minutes)
Details
buildkite/riot-web/jest-tests Passed (4 minutes, 43 seconds)
Details
buildkite/riot-web/pipeline Passed (6 seconds)
Details
Workflow automation moved this from In Review to In Test Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.