Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makeover! #2722

Merged
merged 3 commits into from Dec 9, 2016

Conversation

@dbkr
Copy link
Member

dbkr commented Dec 8, 2016

Also add script for generating the PNGs and add pre-rendered PNGs
for the Linux electron build which means you don't need icns2png
to build it and the Linux icons are straight from the SVG rather
than resized bitmaps.

Makeover!
Also add script for generating the PNGs and add pre-rendered PNGs
for the Linux electron build which means you don't need icns2png
to build it and the Linux icons are straight from the SVG rather
than resized bitmaps.
@dbkr dbkr requested a review from richvdh Dec 8, 2016
@richvdh
richvdh approved these changes Dec 8, 2016
Copy link
Member

richvdh left a comment

lgtm otherwise


tmpdir=`mktemp -d 2>/dev/null || mktemp -d -t 'icontmp'`

for i in 1024 512 256 192 310 180 144 152 150 128 120 114 96 76 72 70 64 60 57 48 36 32 24 16

This comment has been minimized.

Copy link
@richvdh

richvdh Dec 8, 2016

Member

some sort of ordering here?

dbkr added 2 commits Dec 8, 2016
@dbkr dbkr merged commit 3921aa4 into develop Dec 9, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details
@dbkr dbkr deleted the dbkr/icons branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.