Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the 'loading' tests work in isolation #2727

Merged
merged 1 commit into from Dec 9, 2016

Conversation

@dbkr
Copy link
Member

dbkr commented Dec 9, 2016

The 'loading' tests only worked when run with the other tests and
failed if you just ran the file by itself, because the skin was
loading in the 'joining' tests, but not here.

The 'loading' tests only worked when run with the other tests and
failed if you just ran the file by itself, because the skin was
loading in the 'joining' tests, but not here.
@dbkr dbkr requested a review from richvdh Dec 9, 2016
@richvdh
richvdh approved these changes Dec 9, 2016
@richvdh richvdh merged commit b06cff7 into develop Dec 9, 2016
0 of 4 checks passed
0 of 4 checks passed
VectorWebBranches Build #507 origin/dbkr/make_loading_tests_work_alone failed in 6 min 38 sec
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
default Build finished.
Details
@dbkr dbkr deleted the dbkr/make_loading_tests_work_alone branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.