Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests #2730

Merged
merged 1 commit into from Dec 9, 2016

Conversation

@dbkr
Copy link
Member

dbkr commented Dec 9, 2016

Promises are now not being resolved within the same tick, so give
another tick for the UI to update after all the HTTP calls have
flushed through. This is fairly terrible, but I can't immediately
see a better way of doing this.

Promises are now not being resolved within the same tick, so give
another tick for the UI to update after all the HTTP calls have
flushed through. This is fairly terrible, but I can't immediately
see a better way of doing this.
@richvdh
richvdh approved these changes Dec 9, 2016
@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Dec 9, 2016

Ick, but ok.

Ftr you can just do .delay(1) instead of .then(function() { return q.delay(1); })

@richvdh richvdh merged commit 8097b15 into develop Dec 9, 2016
4 checks passed
4 checks passed
VectorWebBranches Build #508 origin/dbkr/fix_test_breakage succeeded in 6 min 11 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
default Build finished.
Details
@dbkr dbkr deleted the dbkr/fix_test_breakage branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.