Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make electron send email validation URLs with a nextlink of riot.im #2808

Merged
merged 3 commits into from Dec 24, 2016

Conversation

@ara4n
Copy link
Member

ara4n commented Dec 24, 2016

rather than file:///, which crashes browsers in horrible ways c.f. https://twitter.com/agumonkey/status/812060535567040512. This was already worked around on sydent.

…ather than file:///
@ara4n

This comment has been minimized.

Copy link
Member Author

ara4n commented Dec 24, 2016

Copy link
Member

richvdh left a comment

looks ok as a temporary fix

window.location.pathname +
'#/register';
if (window.location.protocol === "file:") {
return 'https://riot.im/app/#/register';

This comment has been minimized.

Copy link
@richvdh

richvdh Dec 24, 2016

Member

This really ought to be configurable. Can we make it pull it from the config file?

This comment has been minimized.

Copy link
@ara4n

ara4n Dec 24, 2016

Author Member

yes, we can. but riot.im/app is hardcoded elsewhere right now, and we'll have to tidy this up later; i want to ship this.

@ara4n ara4n merged commit b06d045 into develop Dec 24, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.