Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully fix Windows shortcuts #2917

Merged
merged 1 commit into from Jan 12, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Jan 11, 2017

  • Revert 79d1643
    as it seems to break shortcuts altogether
  • Update electron-builder (and add the squirrel windows package
    that the newer version now requires: it's been split out). This
    uses a newer version of squirrel which has some fixes for
    shortcuts.

I'm unsure exactly what was going wrong originally in
#2775 but 79d1643
seems to break shortcut creation as far as I can see.

 * Revert 79d1643
   as it seems to break shortcuts altogether
 * Update electron-builder (and add the squirrel windows package
   that the newer version now requires: it's been split out). This
   uses a newer version of squirrel which has some fixes for
   shortcuts.

I'm unsure exactly what was going wrong originally in
#2775 but #79d1643
seems to break shortcut creation as far as I can see.
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jan 11, 2017

if this actually works (please test on a virgin ambox) then go for it. Previously the symlink was created but went to the wrong path.

@dbkr

This comment has been minimized.

Copy link
Member Author

dbkr commented Jan 11, 2017

Have tested it on a fresh VM and it works

@dbkr dbkr merged commit 717aa94 into develop Jan 12, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.