Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README now the js-sdk has a transpile step #2921

Merged
merged 2 commits into from Jan 12, 2017

Conversation

@dbkr
Copy link
Member

dbkr commented Jan 11, 2017

No description provided.

README.md Outdated
@@ -58,8 +58,11 @@ to build.
1. Install the prerequisites: `npm install`
1. If you are using the `develop` branch of vector-web, you will probably need
to rebuild one of the dependencies, due to

This comment has been minimized.

Copy link
@richvdh

richvdh Jan 11, 2017

Member

s/one/some

running `npm start` in the directory, to start a development builder which
will watch for changes to the files and rebuild automatically.
When you make changes to `matrix-react-sdk` or `matrix-js-sdk`, you will need
to run `npm run build` in the relevant directory. You can do this automatically

This comment has been minimized.

Copy link
@richvdh

richvdh Jan 11, 2017

Member

Annoyingly, I think it is npm run compile for the js-sdk.

This comment has been minimized.

Copy link
@richvdh

richvdh Jan 11, 2017

Member

It would obviously be preferable to fix this by bringing the js-sdk into line.

This comment has been minimized.

Copy link
@dbkr

dbkr Jan 11, 2017

Author Member

Fixed in matrix-org/matrix-js-sdk#320 by having npm run build do the things you need (and more!)

README.md Outdated
https://github.com/npm/npm/issues/3055: `(cd node_modules/matrix-react-sdk
&& npm install)`
https://github.com/npm/npm/issues/3055:
```
@dbkr

This comment has been minimized.

Copy link
Member Author

dbkr commented Jan 11, 2017

ptal

Copy link
Member

richvdh left a comment

lgtm

@richvdh richvdh assigned dbkr and unassigned richvdh Jan 11, 2017
@dbkr dbkr merged commit 9caba57 into develop Jan 12, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.